Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.00%. Comparing base (12ec3d5) to head (cf8971d).

@@             Coverage Diff              @@
##           unstable    #1559      +/-   ##
============================================
+ Coverage     70.98%   71.00%   +0.01%     
============================================
  Files           121      121              
  Lines         65176    65176              
============================================
+ Hits          46264    46276      +12     
+ Misses        18912    18900      -12     

Trying to understand the issue. AFAIK changing the lolwut can break some clients using it in order to get the current verison.
I agree that providing the unstable version is problematic and we might want to do the same as we did with the info server version (i.e use fixed 7.2.4).

The other issue is that we also have the "Easter eggs" lolwat (which are somewhat broken, for example you cannot enter lolwut which are also presenting the VALKEY_VERSION version and Redis brand (I wonder if these we can be changed).

In anycase I think this should be marked as a breaking change

@sarthakaggarwal97 I just looked. seems like @zuiderkwast suggestion to control this feature via extended-redis-compat might be fine.

@ranshid @zuiderkwast if I understand this correctly, extended-redis-compat is stemming from #274 right?

I see we have a configuration available in valkey.conf as extended-redis-compatibility. So we can continue with this change relying on this configuration?

@ranshid @zuiderkwast if I understand this correctly, extended-redis-compat is stemming from #274 right?

I see we have a configuration available in valkey.conf as extended-redis-compatibility. So we can continue with this change relying on this configuration?

That's right. I think it's OK to use this config for lolwut. We should make a TSC decision about it though.

I remember when we added this config, there were some concerns that it will give us a lot of extra maintenance work, so we decided to limit the scope to only a few things and to make it temporary and be phased out in 9.0. See the test "Extended Redis Compatibility config" in tests/unit/other.tcl

Will just ask again:
why not rebrand the lolwut5Command and lolwut6Command?